added an override to allow fog configuration per uploader #878

Merged
merged 1 commit into from Oct 31, 2012

Conversation

Projects
None yet
2 participants
Contributor

dei79 commented Oct 19, 2012

Added an override to allow to configure the uploader specific
configurations, e.g. S3 bucket or S3 account per uploader instance in
addition to the general configuration from the initializers

@dei79 @dei79 dei79 added an override to allow fog configuration per uploader
Added an override to allow to configure the uploader specific
configurations, e.g. S3 bucket or S3 account per uploader instance in
addition to the general configuration from the initializers
6c0652d
Contributor

dei79 commented Oct 29, 2012

Any news from my pulll request? Would be cool to bring this feature in an official release. I'm currently using it without any issues in production the last 2 weeks :-)

Owner

thiagofm commented Oct 31, 2012

Hi @dei79

Sorry for the delay, Travis CI was having some issues not running the new pull requests in our repository.

Anyways, I would be very glad if you also add an article in the wiki with your feature.

Carrierwave likes your contribution very much ✌️

@thiagofm thiagofm added a commit that referenced this pull request Oct 31, 2012

@thiagofm thiagofm Merge pull request #878 from dei79/per-uploader-config-squashed
added an override to allow fog configuration per uploader
0206f80

@thiagofm thiagofm merged commit 0206f80 into carrierwaveuploader:master Oct 31, 2012

1 check failed

default The Travis build failed
Details
Contributor

dei79 commented Oct 31, 2012

I added a short article in the wiki and created the link on the main page. The article can be found under the following URL: https://github.com/jnicklas/carrierwave/wiki/How-to%3A-Define-configuration-settings-per-uploader

How comes this change into the gem on rubygems so that I do not need the git-path in my Gemfile anymore?

Owner

thiagofm commented Oct 31, 2012

@dei79

This will only be added in the next gem release, which should take a while... I advise you to use the git path until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment