Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

carrot-maven-scr-plugin only works with patched version of annotations #2

Closed
jsievers opened this Issue Oct 30, 2012 · 3 comments

Comments

Projects
None yet
2 participants

I tried combining this plugin with tycho. Everything works fine also in eclipse using the m2e configurator, but I noticed that when I use the original OSGi service annotations, generation will not recognize any annotated classes.

This is because the original OSGi annotations have been patched (or the version is outdated) to use

@retention(RetentionPolicy.RUNTIME)

instead of

@retention(RetentionPolicy.CLASS)

Unfortunately the plugin does its annotation scan using a classloader which only works if annotations are preserved at runtime. Instead of a classloader, I suppose a bytcode library such as e.g. ASM could be used to do the annotation scanning instead.

See tycho enhancement request https://bugs.eclipse.org/bugs/show_bug.cgi?id=392764

@ghost
Contributor

ghost commented Oct 30, 2012

Jan:

thank you for the note;

  1. there are few issues with core/compendium 4.3.X
    https://www.osgi.org/bugzilla/show_bug.cgi?id=147
    https://www.osgi.org/bugzilla/show_bug.cgi?id=151

  2. I was planning to move to ASM anyway, will do this soon.

Andrei.

@ghost
Contributor

ghost commented Feb 24, 2013

resolved starting with v 2.0.0

@ghost ghost closed this Feb 24, 2013

thanks! will give it another try with tycho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment