Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial smoke test #511

Merged
merged 8 commits into from
Nov 22, 2023
Merged

feat: initial smoke test #511

merged 8 commits into from
Nov 22, 2023

Conversation

MilanVojnovic95
Copy link
Collaborator

@MilanVojnovic95 MilanVojnovic95 commented Nov 14, 2023 •
edited
Loading

  • added smoke test for carrot home page
  • checking text
  • checking redirections

Note: currently will work on local since I have added additional selector

It can be optimizes and improved but I wanted to have some checks for start and improve it later

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6a5ed1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
host-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 3:58pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 3:58pm

@MilanVojnovic95 MilanVojnovic95 marked this pull request as ready for review November 16, 2023 20:57
@MilanVojnovic95 MilanVojnovic95 changed the title feat: smoke test [WIP] feat: initial smoke test Nov 21, 2023
@guerrap guerrap merged commit 8564368 into develop Nov 22, 2023
1 of 4 checks passed
luzzif pushed a commit that referenced this pull request Nov 29, 2023
@MilanVojnovic95 @guerrap @luzzif
feat: initial smoke test (#511)
1615400 
* feat: smoke test [WIP]

* feat(qa): smoke test [WIP]

* feat(qa): added more steps, selectors [WIP]

* feat(qa): added additional assertions for smoke

* feat(qa): fixing comments

* feat(qa): edit script

* fix(frontend): add yarn prefix to script

---------

Co-authored-by: Paolo Guerra <pg.guerrap@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerrap guerrap guerrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilanVojnovic95 @guerrap