Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Minimal version overwrites a website’s own Entypo #93

Closed
charakterziffer opened this Issue · 4 comments

3 participants

@charakterziffer

The website dradiowissen.de uses the minimal share-button (v2) along with an own version of Entypo.

The problem: The share-button will (correctly) be loaded after the rest of the site. Then the minimal version of share-button’s Entypo overwrites the already loaded full Entypo. The result is – at least in Firefox – that the icons from the full Entypo get replaced by placeholders. See it yourself for example at http://dradiowissen.de/beitrag/green-goes-black-the-roots-freidenker-nas-omar-jay-z-the-pharcyde (icons at the top right).

fehlende-zeichen

A solution would be to load the minimal Entypo of the share-button under a different name (e.g. “sb-entypo”). This way the minimal share-button could be used on a website that has Entypo already loaded.

@charakterziffer charakterziffer changed the title from Minimal version overwrites a websites own Entypo to Minimal version overwrites a website’s own Entypo
@tmilewski
Owner

You're able to disable the entypo from the configuration:

config = {
  ui: {
    icon_font: false
  }
}

var share = new Share('.share-button', config);

Does this solve your issue?

@tmilewski tmilewski self-assigned this
@charakterziffer

This could help.
dradiowissen.de isn’t my own site, I’m just a fan of the radio station. I’ll send them the link to this thread and hope they’ll fix it.
Thank you!

@tmilewski
Owner

Good looking out! Hopefully that solves the issue. One thing to keep in mind is that this is a later addition to the library. They might need to update for that feature.

@portnull

@charakterziffer thanks for spotting this and thanks @tmilewski for your help. we will implement the fix with the next release. happy listening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.