diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index cfb9d418ffbaa..61fba6f264b52 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -8,6 +8,10 @@ - `TextControl`: Add typings for `date`, `time` and `datetime-local` ([#59666](https://github.com/WordPress/gutenberg/pull/59666)). +### Internal + +- `Button`: Keep deprecated props in type definitions ([#59913](https://github.com/WordPress/gutenberg/pull/59913)). + ## 27.1.0 (2024-03-06) ### Bug Fix diff --git a/packages/components/src/button/index.tsx b/packages/components/src/button/index.tsx index a16f190e44704..f1dcd86fb59a5 100644 --- a/packages/components/src/button/index.tsx +++ b/packages/components/src/button/index.tsx @@ -65,10 +65,9 @@ function useDeprecatedProps( { } if ( isDefault ) { - deprecated( 'Button isDefault prop', { + deprecated( 'wp.components.Button `isDefault` prop', { since: '5.4', alternative: 'variant="secondary"', - version: '6.2', } ); computedVariant ??= 'secondary'; @@ -87,7 +86,7 @@ function useDeprecatedProps( { } export function UnforwardedButton( - props: ButtonProps, + props: ButtonProps & DeprecatedButtonProps, ref: ForwardedRef< any > ) { const { diff --git a/packages/components/src/button/test/index.tsx b/packages/components/src/button/test/index.tsx index 699db1b75429f..2b4a610c50bea 100644 --- a/packages/components/src/button/test/index.tsx +++ b/packages/components/src/button/test/index.tsx @@ -554,13 +554,11 @@ describe( 'Button', () => { describe( 'deprecated props', () => { it( 'should not break when the legacy isPrimary prop is passed', () => { - // @ts-expect-error render(