Remove duplicate null check #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunogaspar
reviewed
Sep 10, 2019
| @@ -309,7 +309,7 @@ public function authenticate($credentials, bool $remember = false, bool $login = | |||
|
|
|||
| $valid = $user !== null ? $this->users->validateCredentials($user, $credentials) : false; | |||
|
|
|||
| if ($user === null || ! $valid) { | |||
| if (! $valid) { | |||
There was a problem hiding this comment.
The check seems different now i suppose, since above it checks user is not null, here it was checking user was null and not valid.
There was a problem hiding this comment.
$user can only be null or EloquentUser. If user is null, valid will always be false because the user is null.
If the comparison was && instead of ``||``` I would understand keeping the null check but in the current state $valid can never be true if $user is null.
There was a problem hiding this comment.
Sorry, i misread the code when i commented out.
It makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this null check isn't needed as it's already checked in the line above.
edit: the default callback type for
Sentinel::registershould be a bool.