Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dangerous-disable-gk-scoping should only be available in kapp deploy #750

Closed
praveenrewar opened this issue May 11, 2023 · 3 comments · Fixed by #752
Closed

--dangerous-disable-gk-scoping should only be available in kapp deploy #750

praveenrewar opened this issue May 11, 2023 · 3 comments · Fixed by #752
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.

Comments

@praveenrewar
Copy link
Member

During kapp deploy, we scope the listing of resources to only the GKs of the resources provided through -f, but we don't scope the listing in kapp insepct or kapp deploy, hence the flag --dangerous-disable-gk-scoping should only be made available in the kapp deploy command.

Environment:

  • kapp version (use kapp --version):
  • OS (e.g. from /etc/os-release):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@praveenrewar praveenrewar added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels May 11, 2023
@100mik 100mik added the good first issue An issue that will be a good candidate for a new contributor label May 11, 2023
@praveenrewar praveenrewar added the priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. label May 11, 2023
@praveenrewar
Copy link
Member Author

If anyone wants to work on this issue:

@hernandanielg
Copy link
Contributor

Hey @praveenrewar I haven't seen the code but will give this a try!!! 😅 - wish me luck!

@praveenrewar
Copy link
Member Author

Thank you so much @hernandanielg!! I have assigned the issue to you. Good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants