New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved docs. #117

Merged
merged 5 commits into from Nov 6, 2017

Conversation

Projects
None yet
4 participants
@shibasisp
Contributor

shibasisp commented Aug 12, 2017

  • In this page, some of the examples are not related to the section(heading). Like in functionals.poly section, the example was given is of gaussian1d.I had tried to remove the duplicity.
  • Added some more points regarding creating a spectral coordinate and other coordinates.

shibasisp added some commits Jul 7, 2017

Added docs for coordinates.py
Spectral coordinates is the 4th axis of an image and can only be created with a 4d image.
@pep8speaks

This comment has been minimized.

pep8speaks commented Aug 12, 2017

Hello @shibasisp! Thanks for updating the PR.

Line 462:80: E501 line too long (80 > 79 characters)
Line 594:80: E501 line too long (87 > 79 characters)

Line 87:80: E501 line too long (84 > 79 characters)
Line 166:65: E502 the backslash is redundant between brackets
Line 169:60: E502 the backslash is redundant between brackets
Line 184:9: E722 do not use bare except'
Line 194:9: E722 do not use bare except'

Line 51:1: E302 expected 2 blank lines, found 1
Line 52:3: E111 indentation is not a multiple of four
Line 58:80: E501 line too long (80 > 79 characters)
Line 61:3: E114 indentation is not a multiple of four (comment)
Line 62:3: E111 indentation is not a multiple of four
Line 65:3: E111 indentation is not a multiple of four
Line 68:3: E114 indentation is not a multiple of four (comment)
Line 69:3: E111 indentation is not a multiple of four
Line 71:1: E302 expected 2 blank lines, found 1
Line 72:3: E111 indentation is not a multiple of four
Line 84:3: E111 indentation is not a multiple of four
Line 87:3: E114 indentation is not a multiple of four (comment)
Line 88:3: E111 indentation is not a multiple of four
Line 91:3: E111 indentation is not a multiple of four
Line 94:3: E114 indentation is not a multiple of four (comment)
Line 95:3: E111 indentation is not a multiple of four
Line 98:1: E302 expected 2 blank lines, found 1
Line 118:80: E501 line too long (80 > 79 characters)
Line 143:80: E501 line too long (81 > 79 characters)
Line 144:5: E722 do not use bare except'
Line 194:80: E501 line too long (82 > 79 characters)
Line 348:80: E501 line too long (108 > 79 characters)
Line 365:80: E501 line too long (119 > 79 characters)
Line 366:80: E501 line too long (82 > 79 characters)
Line 369:80: E501 line too long (80 > 79 characters)
Line 371:80: E501 line too long (118 > 79 characters)
Line 372:80: E501 line too long (96 > 79 characters)
Line 377:80: E501 line too long (112 > 79 characters)
Line 398:16: E127 continuation line over-indented for visual indent
Line 398:80: E501 line too long (80 > 79 characters)
Line 426:9: E722 do not use bare except'
Line 435:17: E722 do not use bare except'
Line 438:9: E722 do not use bare except'
Line 457:80: E501 line too long (82 > 79 characters)
Line 609:80: E501 line too long (80 > 79 characters)
Line 688:80: E501 line too long (89 > 79 characters)
Line 737:80: E501 line too long (80 > 79 characters)
Line 815:80: E501 line too long (81 > 79 characters)
Line 910:45: E703 statement ends with a semicolon
Line 916:80: E501 line too long (80 > 79 characters)
Line 947:80: E501 line too long (85 > 79 characters)
Line 955:80: E501 line too long (80 > 79 characters)
Line 973:80: E501 line too long (80 > 79 characters)
Line 981:80: E501 line too long (85 > 79 characters)
Line 1023:80: E501 line too long (85 > 79 characters)
Line 1029:80: E501 line too long (80 > 79 characters)
Line 1040:80: E501 line too long (83 > 79 characters)
Line 1058:80: E501 line too long (83 > 79 characters)
Line 1067:80: E501 line too long (85 > 79 characters)
Line 1099:80: E501 line too long (80 > 79 characters)
Line 1105:80: E501 line too long (83 > 79 characters)
Line 1214:80: E501 line too long (80 > 79 characters)
Line 1239:80: E501 line too long (86 > 79 characters)
Line 1283:80: E501 line too long (82 > 79 characters)
Line 1285:80: E501 line too long (83 > 79 characters)
Line 1348:80: E501 line too long (83 > 79 characters)
Line 1448:11: E111 indentation is not a multiple of four
Line 1450:11: E111 indentation is not a multiple of four
Line 1469:80: E501 line too long (80 > 79 characters)
Line 1479:80: E501 line too long (80 > 79 characters)
Line 1496:80: E501 line too long (80 > 79 characters)
Line 1498:80: E501 line too long (80 > 79 characters)
Line 1516:80: E501 line too long (80 > 79 characters)
Line 1619:80: E501 line too long (80 > 79 characters)
Line 1649:80: E501 line too long (85 > 79 characters)
Line 1650:80: E501 line too long (115 > 79 characters)
Line 1809:80: E501 line too long (80 > 79 characters)
Line 1810:80: E501 line too long (92 > 79 characters)
Line 1847:80: E501 line too long (81 > 79 characters)
Line 1872:80: E501 line too long (90 > 79 characters)
Line 1881:80: E501 line too long (81 > 79 characters)
Line 1890:80: E501 line too long (108 > 79 characters)
Line 1892:80: E501 line too long (84 > 79 characters)
Line 1893:80: E501 line too long (95 > 79 characters)

Comment last updated on August 12, 2017 at 06:25 Hours UTC
@coveralls

This comment has been minimized.

coveralls commented Aug 12, 2017

Coverage Status

Coverage increased (+0.6%) to 63.594% when pulling 49e55ed on shibasisp:docs into ace5ead on casacore:master.

@coveralls

This comment has been minimized.

coveralls commented Aug 12, 2017

Coverage Status

Coverage increased (+0.6%) to 63.594% when pulling 1401141 on shibasisp:docs into ace5ead on casacore:master.

@gijzelaerr gijzelaerr merged commit 674ba1b into casacore:master Nov 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 63.594%
Details

@gijzelaerr gijzelaerr added this to the 2.2 milestone Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment