Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made doctests compatible and did minor changes to look code more pythonic #89

Merged
merged 3 commits into from Jun 6, 2017

Conversation

@shibasisp
Copy link
Contributor

@shibasisp shibasisp commented May 30, 2017

No description provided.

@coveralls
Copy link

@coveralls coveralls commented May 30, 2017

Coverage Status

Coverage decreased (-0.2%) to 53.149% when pulling 877e68a on shibasisp:utils into 0c1aa40 on casacore:master.


def getlocals(back=2):
"""Get the local variables some levels back (-1 is top)."""
import inspect
fr = inspect.currentframe()
try:
while fr and back != 0:
while fr and back:

This comment has been minimized.

@tammojan

tammojan May 30, 2017
Contributor

I think this change makes the code less clear.

This comment has been minimized.

@shibasisp

shibasisp May 30, 2017
Author Contributor

I will reverse it back. Rest all are okay?

This comment has been minimized.

@tammojan

tammojan May 31, 2017
Contributor

Looks good to me!

@tammojan
Copy link
Contributor

@tammojan tammojan commented May 31, 2017

I updated coveralls to allow a decrease in coverage of 1% or so to avoid silly rejections like this.

@coveralls
Copy link

@coveralls coveralls commented May 31, 2017

Coverage Status

Coverage decreased (-0.2%) to 53.149% when pulling 38a85e8 on shibasisp:utils into 0c1aa40 on casacore:master.

@tammojan tammojan merged commit ce5c69d into casacore:master Jun 6, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 53.149%
Details
@gijzelaerr gijzelaerr added this to the 2.2 milestone Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants