Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfixed formatting and clean up for tables #98
Conversation
shibasisp
added some commits
Jun 10, 2017
shibasisp
force-pushed the
shibasisp:table
branch
from
3dd3ce4
to
17fafd2
Jun 15, 2017
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jun 15, 2017
•
| @@ -1796,19 +1795,18 @@ def browse(self, wait=True, tempname="/tmp/seltable"): | ||
| os.system('casabrowser ' + self.name() + waitstr1) | ||
| elif len(tempname) > 0: | ||
| six.print_(" making a persistent copy in table " + tempname) | ||
| tx = self.copy(tempname) | ||
| tx = 0 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shibasisp
Jun 16, 2017
Contributor
tx is a local variable and I don't see anywhere else in the method, it is being used. Moreover, tx is assigned 0 immediately after it has been assigned self.copy(tempname) which makes the assignment of self.copy(tempname) irrelevant .Its value won't change dynamically, so,I removed it.
This comment has been minimized.
This comment has been minimized.
tammojan
Jun 16, 2017
Contributor
self.copy has side effects (namely it creates a new file). So please do not remove the line. I think replacing these two lines with just
self.copy(tempname) would be ok, since indeed the return value is not used.
This comment has been minimized.
This comment has been minimized.
gervandiepen
Jun 19, 2017
Contributor
I think the changes are fine and can be merged. Tammo, do you do that?
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jun 16, 2017
•
tammojan
merged commit d6834d5
into
casacore:master
Jun 19, 2017
gijzelaerr
added this to the 2.2 milestone
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
shibasisp commentedJun 14, 2017
No description provided.