Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Matrix::get, Matrix::set #1360

Closed
jaeandersson opened this issue Mar 16, 2015 · 0 comments
Closed

Refactor Matrix::get, Matrix::set #1360

jaeandersson opened this issue Mar 16, 2015 · 0 comments
Assignees
@jaeandersson
Labels
enhancement
Milestone
Version 2.3.0

Comments

@jaeandersson
Copy link
Member

The Matrix::get, Matrix::set, Matrix::getArray etc. routines are neither maintainable (look at the typemaps), nor complete (some options will throw errors). They also have public API including vector<SXElement> and SXElement (which should not be allowed, cf. #1322).

Furthermore, there is a serious ambiguity problem, where Matrix::set(vector<DataType>) means one thing and ``Matrix::set(Matrix(vector))` means something else.

This will require refactoring and unavoidable syntax change (to resolve the ambiguity).
@jaeandersson jaeandersson self-assigned this Mar 16, 2015
@jaeandersson jaeandersson added this to the Version 2.4.0 milestone Mar 16, 2015
@jaeandersson jaeandersson mentioned this issue Mar 16, 2015
Closed
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Matrix, MX::getNZ return-by-reference in C++
8a41fb1
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Matrix, MX::getSub return-by-reference in C++
ac02b93
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Added numeric Matrix::getSub, setSub, getNZ, setNZ
67287a7
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Renamed Matrix::set(Matrix), get(Matrix) overload
81bb14b
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::set(double), get(double)
96a2216
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Updated Matrix::set overloads
6202f0a
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Updated Matrix::set overloads (2)
373b79c
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::set(double*), get(double*)
397d97a
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::set(vector<double>), get(vector<double>)
b7eda81
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::getArray(DataType*), setArray(DataType*)
a718574
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::getArray(DataType*), setArray(DataType*) (2)
fd8bcf1
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed Matrix::getArray
70be5fb
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Cleaned up typemaps
0b535be
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Removed remaining Matrix::get
949b696
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Updated examples
72e823e
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Renamed Matrix::setSub --> Matrix::set
c37bc9d
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Renamed Matrix::getSub --> Matrix::get
1c0ee6d
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Fixed WORHP
9a8b47f
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Fixed WORHP (2)
6368ee6
jaeandersson added a commit that referenced this issue Mar 17, 2015
@jaeandersson
#1360 Fixed lint
8458c59
jaeandersson added a commit that referenced this issue Mar 19, 2015
@jaeandersson
#1360 Resolved SWIG warning
972df10
jaeandersson added a commit that referenced this issue Mar 20, 2015
@jaeandersson
#1360 Return-by-value in SWIG for all Matrix::get* overloads
7347188
jaeandersson added a commit that referenced this issue Apr 8, 2015
@jaeandersson @jgillis
#1360 Resolved SWIG warning
4c46565
jaeandersson added a commit that referenced this issue Apr 8, 2015
@jaeandersson @jgillis
#1360 Return-by-value in SWIG for all Matrix::get* overloads
3b0d7a1
@jgillis jgillis mentioned this issue Jan 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaeandersson jaeandersson

Labels
enhancement
Projects
None yet
Milestone
Version 2.3.0
Development

No branches or pull requests
1 participant
@jaeandersson