Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated code compilable with -Wall -Werror #1741

Closed
jaeandersson opened this issue Mar 29, 2016 · 3 comments
Closed

Make generated code compilable with -Wall -Werror #1741

jaeandersson opened this issue Mar 29, 2016 · 3 comments
Assignees
Milestone

Comments

@jaeandersson
Copy link
Member

@jaeandersson jaeandersson commented Mar 29, 2016

Compiling generated code with -Wall will result in unused variables warnings (and possibly other warnings). These originate both from e.g. iterators that may or may not be used and from unused function arguments.

@jaeandersson jaeandersson self-assigned this Mar 7, 2017
@jaeandersson jaeandersson added this to the Version 3.2 milestone Mar 7, 2017
jaeandersson added a commit that referenced this issue Mar 7, 2017
jaeandersson added a commit that referenced this issue Mar 7, 2017
@jaeandersson
Copy link
Member Author

@jaeandersson jaeandersson commented Mar 10, 2017

undefined-variable is now mostly resolved. @ghorn @jgillis, let me know if you still get these warnings from somewhere. Or other warnings from -Wall (but not -Wextra).

Loading

@jaeandersson
Copy link
Member Author

@jaeandersson jaeandersson commented Mar 30, 2017

You get warnings if you enable -Wmissing-prototypes or -Wunused-parameter. Neither is part of -Wall, though.

Loading

@jaeandersson
Copy link
Member Author

@jaeandersson jaeandersson commented Mar 30, 2017

Resolved as far as I can tell.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant