Skip to content

Make generated code compilable with -Wall -Werror #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaeandersson opened this issue Mar 29, 2016 · 3 comments
Closed

Make generated code compilable with -Wall -Werror #1741

jaeandersson opened this issue Mar 29, 2016 · 3 comments
Assignees
@jaeandersson
Labels
enhancement minor
Milestone
Version 3.2

Comments

@jaeandersson
Copy link
Member

Compiling generated code with -Wall will result in unused variables warnings (and possibly other warnings). These originate both from e.g. iterators that may or may not be used and from unused function arguments.
This was referenced Oct 18, 2016
Closed
Closed
@jaeandersson jaeandersson self-assigned this Mar 7, 2017
@jaeandersson jaeandersson added this to the Version 3.2 milestone Mar 7, 2017
jaeandersson added a commit that referenced this issue Mar 7, 2017
@jaeandersson
Issue #1741 Prettier codegen
595e287
jaeandersson added a commit that referenced this issue Mar 7, 2017
@jaeandersson
Issue #1741 Prettier codegen (2)
d5f34ff
jaeandersson added a commit that referenced this issue Mar 8, 2017
@jaeandersson
Issue #1741 Refactored casadi_math::print*
8619114
jaeandersson added a commit that referenced this issue Mar 8, 2017
@jaeandersson
Issue #1741 Refactored casadi_math::print
8a3ede8
jaeandersson added a commit that referenced this issue Mar 8, 2017
@jaeandersson
Issue #1741 Removed CodeGenerator::assign
9ace439
jaeandersson added a commit that referenced this issue Mar 8, 2017
@jaeandersson
Issue #1741 Abstracted CodeGenerator::body -> CodeGenerator::operator<<
b3f6d0d
jaeandersson added a commit that referenced this issue Mar 9, 2017
@jaeandersson
Issue #1741 Implemented auto-indentation
b9893ca
jaeandersson added a commit that referenced this issue Mar 9, 2017
@jaeandersson
Issue #1741 Auto-indentation in codegen
440c1ca
jaeandersson added a commit that referenced this issue Mar 9, 2017
@jaeandersson
Issue #1741 Fixed indentation in Map codegen
d1905f4
jaeandersson added a commit that referenced this issue Mar 9, 2017
@jaeandersson
Issue #1741 CodeGenerator keeping track of local variables
e9275ef
jaeandersson added a commit that referenced this issue Mar 9, 2017
@jaeandersson
Issue #1741 cr, cs, ct only code generated if used
0f759ab
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 Brackets in codegen have side effect of indentation
1dd4d16
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 cii only generated if used
faa1305
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 ii,jj,kk only generated if used
a76824b
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 rr,ss,tt only generated if used
c081ac3
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 r,s,t only generated if used
bd67dca
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 i,j,k only generated if used
fcaf3fd
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 Avoiding unused variables in Switch codegen
b61eb6f
jaeandersson added a commit that referenced this issue Mar 10, 2017
@jaeandersson
Issue #1741 Avoiding unused arg1, res1 in MXFunction
2095fed
@jaeandersson
Copy link
Member Author

jaeandersson commented Mar 10, 2017 •
edited
Loading

undefined-variable is now mostly resolved. @ghorn @jgillis, let me know if you still get these warnings from somewhere. Or other warnings from -Wall (but not -Wextra).

@jaeandersson
Copy link
Member Author

jaeandersson commented Mar 30, 2017 •
edited
Loading

You get warnings if you enable -Wmissing-prototypes or -Wunused-parameter. Neither is part of -Wall, though.

@jaeandersson
Copy link
Member Author

Resolved as far as I can tell.

jaeandersson added a commit that referenced this issue Apr 3, 2017
@jaeandersson
Issue #1741 Enabled -Wall -Werror in unit tests
6ca3c9b
jaeandersson added a commit that referenced this issue Apr 4, 2017
@jaeandersson
Issue #1741 Fixed bug in Switch codegen
970f02b
jaeandersson added a commit that referenced this issue Apr 4, 2017
@jaeandersson
Issue #1741 Fixed bug in Switch codegen (2)
6761fdb
jaeandersson added a commit that referenced this issue Apr 4, 2017
@jaeandersson
Issue #1741 Resolved warnings in Einstein codegen
8fb49bb
jaeandersson added a commit that referenced this issue Apr 4, 2017
@jaeandersson
Issue #1741 Suppressed -Wunknown_pragmas for codegen testing
73d1b41
jaeandersson added a commit that referenced this issue Apr 4, 2017
@jaeandersson
Issue #1741 Resolved -Wunused-but-set-variable warning
fd5ffc0
jaeandersson added a commit that referenced this issue May 15, 2017
@jaeandersson
Issue #1741 Resolved bug in mem.h
6088c0c
@jaeandersson jaeandersson mentioned this issue May 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaeandersson jaeandersson

Labels
enhancement minor
Projects
None yet
Milestone
Version 3.2
Development

No branches or pull requests
1 participant
@jaeandersson