New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor WITH_SELFCONTAINED CMake option #1990

Closed
jaeandersson opened this Issue Apr 24, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@jaeandersson
Member

jaeandersson commented Apr 24, 2017

The WITH_SELFCONTAINED option looks like a weird design to me. Isn't a more natural design to allow the user to override LIBRARY DESTINATION, ARCHIVE DESTINATION and RUNTIME DESTINATION?

      install(TARGETS ${name}
        LIBRARY DESTINATION ${CASADI_LIBRARY_DESTINATION}
        ARCHIVE DESTINATION ${CASADI_ARCHIVE_DESTINATION}
        RUNTIME DESTINATION ${CASADI_RUNTIME_DESTINATION}
      )

Cf. #1988 #1989

@jaeandersson jaeandersson added this to the Version 3.2 milestone Apr 24, 2017

@jaeandersson jaeandersson self-assigned this Apr 24, 2017

@jaeandersson

This comment has been minimized.

Member

jaeandersson commented Apr 24, 2017

Ping @jgillis

jaeandersson added a commit that referenced this issue Apr 25, 2017

Issue #1990 Added INSTALL_LIB_DIR, INSTALL_BIN_DIR, INSTALL_INCLUDE_D…
…IR, INSTALL_CMAKE_DIR cmake cache paths
@jgillis

This comment has been minimized.

Member

jgillis commented Apr 25, 2017

Legacy, from a time where the build system was going through rough waters, and i needed to deploy binaries.

jaeandersson added a commit that referenced this issue Apr 25, 2017

jaeandersson added a commit that referenced this issue Apr 25, 2017

jaeandersson added a commit that referenced this issue Apr 25, 2017

Issue #1990 WITH_SELFCONTAINED option just sets default installation …
…prefices to a flat hierarchy and modifies rpath

jaeandersson added a commit that referenced this issue Apr 25, 2017

@jaeandersson

This comment has been minimized.

Member

jaeandersson commented May 21, 2017

It ended up not getting removed, but refactored.

@jaeandersson jaeandersson changed the title from Remove WITH_SELFCONTAINED CMake option to Refactor WITH_SELFCONTAINED CMake option May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment