New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure CSparse derived methods are properly attributed #2134

Closed
jaeandersson opened this Issue Nov 22, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@jaeandersson
Member

jaeandersson commented Nov 22, 2017

Some routines in Sparsity(Internal) have implementations derived from CSparse. This should be pointed out more clearly in the code and proper copyright statements must be included. Likewise, most of the routines in casadi_qr.hpp and casadi_ldl.hpp are derived from code listed in the Tim Davis book and user guide respectively. This needs to be clarified and caution must be taken so that this code isn't copied to autogenerated code in breach of copyright restrictions.

jaeandersson added a commit that referenced this issue Nov 22, 2017

jaeandersson added a commit that referenced this issue Nov 26, 2017

Issue #2134 Moved licence restricted functions out of casadi_qr.hpp
These routines can be part of CasADi, with proper attribution, but cannot be used in C code generation without
added licence restrictions to the C code.
Sparsity pattern routines were moved to SparsityInternal class and 'casadi_qr' was moved to a temporary place in
casadi_runtime.hpp (from where it cannot be code generated). This function needs to either be replaced by non-copyrighted
code or have it's implementation distributed as a separate LGPL licended runtime library with dynamic linkage.

jaeandersson added a commit that referenced this issue Nov 26, 2017

jaeandersson added a commit that referenced this issue Dec 7, 2017

@jgillis

This comment has been minimized.

Member

jgillis commented Dec 21, 2017

close?

@jaeandersson

This comment has been minimized.

Member

jaeandersson commented Jan 7, 2018

I think there might be some more things to do. I'll double check when I'm back in Madison.

jaeandersson added a commit that referenced this issue Jan 24, 2018

Issue #2134 Reorganized LDL derived routines
Proper attribution as derivative codes under LGPL
Moved casadi_ldl to casadi_runtime.hpp, avoiding copyright infringement if/when code generation is enabled.

@jaeandersson jaeandersson self-assigned this Jan 24, 2018

@jaeandersson jaeandersson added the task label Jan 24, 2018

@jaeandersson jaeandersson added this to the Version 3.4 milestone Jan 24, 2018

@jaeandersson

This comment has been minimized.

Member

jaeandersson commented Jan 24, 2018

Done, spun #2158. Need to make sure we document this in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment