Skip to content

Make sure CSparse derived methods are properly attributed #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaeandersson opened this issue Nov 22, 2017 · 3 comments
Closed

Make sure CSparse derived methods are properly attributed #2134

jaeandersson opened this issue Nov 22, 2017 · 3 comments
Assignees
@jaeandersson
Labels
task
Milestone
Version 3.4

Comments

@jaeandersson
Copy link
Member

Some routines in Sparsity(Internal) have implementations derived from CSparse. This should be pointed out more clearly in the code and proper copyright statements must be included. Likewise, most of the routines in casadi_qr.hpp and casadi_ldl.hpp are derived from code listed in the Tim Davis book and user guide respectively. This needs to be clarified and caution must be taken so that this code isn't copied to autogenerated code in breach of copyright restrictions.
jaeandersson added a commit that referenced this issue Nov 22, 2017
@jaeandersson
Issue #2134 Added Tim Davis attribution and copyright to Sparsity::amd
c4da1df
jaeandersson added a commit that referenced this issue Nov 26, 2017
@jaeandersson
Issue #2134 Moved licence restricted functions out of casadi_qr.hpp
25cf431 
These routines can be part of CasADi, with proper attribution, but cannot be used in C code generation without
added licence restrictions to the C code.
Sparsity pattern routines were moved to SparsityInternal class and 'casadi_qr' was moved to a temporary place in
casadi_runtime.hpp (from where it cannot be code generated). This function needs to either be replaced by non-copyrighted
code or have it's implementation distributed as a separate LGPL licended runtime library with dynamic linkage.
jaeandersson added a commit that referenced this issue Nov 26, 2017
@jaeandersson
Issue #2134 Include comment in QR codegen explaining expected missing…
6beb223 
… symbol
jaeandersson added a commit that referenced this issue Dec 7, 2017
@jaeandersson
Issue #2134 Fix comment
760ab19
@jgillis
Copy link
Member

jgillis commented Dec 21, 2017

close?

@jaeandersson
Copy link
Member Author

I think there might be some more things to do. I'll double check when I'm back in Madison.

@jaeandersson jaeandersson mentioned this issue Jan 24, 2018
Closed
jaeandersson added a commit that referenced this issue Jan 24, 2018
@jaeandersson
Issue #2134 Added missing CSparse attributions/copyright
8e260b0
jaeandersson added a commit that referenced this issue Jan 24, 2018
@jaeandersson
Issue #2134 Reorganized LDL derived routines
ee27425 
Proper attribution as derivative codes under LGPL
Moved casadi_ldl to casadi_runtime.hpp, avoiding copyright infringement if/when code generation is enabled.
@jaeandersson jaeandersson self-assigned this Jan 24, 2018
@jaeandersson jaeandersson added this to the Version 3.4 milestone Jan 24, 2018
@jaeandersson
Copy link
Member Author

Done, spun #2158. Need to make sure we document this in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaeandersson jaeandersson

Labels
task
Projects
None yet
Milestone
Version 3.4
Development

No branches or pull requests
2 participants
@jgillis @jaeandersson