Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low-level functions from Callback #2271

Closed
jaeandersson opened this issue May 18, 2018 · 0 comments

Comments

@jaeandersson
Copy link
Member

commented May 18, 2018

Callback is supposed to be high-level interface to FunctionInternal. Working with work vectors is error prone and should reasonably be removed from any high-level interface.

The following methods are low-level and would be removed:

  • virtual int eval(const double**, double**, casadi_int*, double*, void*) const;
  • eval_sx
  • alloc_w
  • alloc_iw
  • alloc_arg
  • alloc_res

This would also resolve the current problematic infinite loop for CallbackInternal::eval and CallbackInternal::eval_dm (haven't looked deep into this, but the design doesn't look clean).

@jaeandersson jaeandersson self-assigned this May 18, 2018
jaeandersson added a commit that referenced this issue May 18, 2018
jaeandersson added a commit that referenced this issue May 18, 2018
Avoids infinite loops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.