IO Names not checked for uniqueness

[jgillis]

from casadi import *

x = MX.sym("x")
f = Function("f",[x],[x**2,x-2],["x"],["y","y"])
print(f)

[jgillis]

@tmmsartor

[jgillis]

Seems to be violated often internally

[jgillis]

@jaeandersson can you comment please?

[jaeandersson]

Sorry for late answer. You say that it's violated internally. Do you have an example? I thought that was resolved.

[jgillis]

Just add a quick assertion internally and run the unittests..

[jaeandersson]

Oh, I misunderstood. I meant that I thought that the issue of getting duplicate names because of differentiation had been resolved, but this is a different issue.

[jaeandersson]

Added an implementation of the check using hashes (should be faster than string comparison, but probably overkill): a426fa3
Didn't push to develop as it breaks unit tests.

[jaeandersson]

I believe that this is a breaking change. Currently, you'll get duplicate names internally as part of the derivative generation, cf. #2040. Don't think we should disallow duplicate names before we've resolved that issue

[jaeandersson]

#2040 has now been resolved