Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issues on caddyserver.com #1

Closed
magikstm opened this issue Jun 5, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@magikstm
Copy link
Contributor

commented Jun 5, 2019

I believe the issue could be corrected by using a valid release version tag in the form v0.1.0 or v1.0.0.

Ref: https://caddy.community/t/plugins-having-build-issues-as-of-05-06-2019/5817

@hsluoyz

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Hi @magikstm , can you help make a PR?

UPDATE

Is this as simple as I release the v1.0.0 version of this project at GitHub? If yes, I can do it now.

@hsluoyz hsluoyz self-assigned this Jun 5, 2019

@hsluoyz hsluoyz added the bug label Jun 5, 2019

@magikstm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

I believe it is as simple as releasing v1.0.0 of the plugin then making it visible on the Caddy build server.

@magikstm

This comment has been minimized.

@hsluoyz

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Hi @magikstm , I have released v1.0.0: https://github.com/casbin/caddy-authz/releases/tag/v1.0.0

What do you mean by "making it visible on the Caddy build server"? I think this project is open-source and the release is already visible to anyone including the Caddy build server, right?

@magikstm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

I think you would need to deploy the release in your developer portal account.

Ref: https://github.com/mholt/caddy/wiki/Publishing-a-Plugin-to-the-Download-Page

Link: https://caddyserver.com/account/login

@hsluoyz

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

I have released `v1.0.1``:

image

Thanks for the PR!

@hsluoyz hsluoyz closed this Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.