Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inherit std::exception #112

Merged
merged 1 commit into from
Jun 27, 2021
Merged

feat: Inherit std::exception #112

merged 1 commit into from
Jun 27, 2021

Conversation

EmperorYP7
Copy link
Member

@EmperorYP7 EmperorYP7 commented Jun 25, 2021

Fix: #111

Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in


Description

Incorporated changes suggested by @klemens-morgenstern

Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@hsluoyz
Copy link
Member

hsluoyz commented Jun 27, 2021

@EmperorYP7 fix:

image

@EmperorYP7
Copy link
Member Author

@hsluoyz it's fixed in #109 (removed Azure workflow). The failing test is intended to avoid merge conflict.

@hsluoyz hsluoyz merged commit 1a1ea59 into casbin:master Jun 27, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions should inherit std::exception
2 participants