Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated project config #141

Merged
merged 2 commits into from
Aug 16, 2021
Merged

chore: Updated project config #141

merged 2 commits into from
Aug 16, 2021

Conversation

EmperorYP7
Copy link
Member

@EmperorYP7 EmperorYP7 commented Aug 15, 2021

Signed-off-by: Yash Pandey (YP) yash.btech.cs19@iiitranchi.ac.in

This code:

  • Changes the CMAKE_PROJECT_NAME to casbin and CMAKE_PROJECT_VERSION to 1.37.1
  • Removes unnecessary installations
  • Properly installs pycasbin.so/pycasbin.pyd to its desired path
  • Configures include paths to be inline with the intended client-side configuration

@hsluoyz
Copy link
Member

hsluoyz commented Aug 16, 2021

@EmperorYP7 plz fix: https://github.com/casbin/casbin-cpp/pull/141/checks?check_run_id=3334833781

Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
Signed-off-by: Yash Pandey (YP) <yash.btech.cs19@iiitranchi.ac.in>
@hsluoyz
Copy link
Member

hsluoyz commented Aug 16, 2021

@EmperorYP7 BTW, is the PyCasbin on Casbin-CPP ready for use now?

@EmperorYP7
Copy link
Member Author

@EmperorYP7 BTW, is the PyCasbin on Casbin-CPP ready for use now?

Yes, it is ready for use. I exposed all of the client-side API of casbin to Python. However, casbin::SyncedEnforcer isn't working as expected.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 17, 2021

@EmperorYP7 is it available in pypi? How to use it in the code level, maybe we should provide an example.

@EmperorYP7
Copy link
Member Author

EmperorYP7 commented Aug 17, 2021

@EmperorYP7 is it available in pypi? How to use it in the code level, maybe we should provide an example.

@hsluoyz Nope. Since the actual module is a standalone binary (shared/dynamic library), it cannot be shipped with Pypi. I'll update the docs accordingly. And the usage can be figured out with the tests in tests/python directory.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 17, 2021

@EmperorYP7 how to use it in another project instead of tests/python folder?

@github-actions
Copy link

🎉 This PR is included in version 1.38.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants