Cased CLI integration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewski
commented
Mar 2, 2021
| @@ -2,66 +2,67 @@ PATH | |||
| remote: . | |||
| specs: | |||
| cased-rails (0.3.1) | |||
| cased-ruby (~> 0.3.3) | |||
| cased-ruby (~> 0.4.0) | |||
There was a problem hiding this comment.
Bump cased-ruby to the new version we just published.
| @@ -0,0 +1,15 @@ | |||
| <div id="guard-session-container"> | |||
| <% if guard_session.requested? %> | |||
There was a problem hiding this comment.
These are all the steps a Guard Session can go through and their respective views for each one.
| <% elsif guard_session.reason_required? %> | ||
| <%= render 'cased/cli/sessions/steps/reason_required', guard_session: guard_session %> | ||
| <% else %> | ||
| <%= render 'cased/cli/sessions/steps/create', guard_session: guard_session %> |
There was a problem hiding this comment.
The create step is special in that we need to preserve any form parameters even when unauthenticated, we submit the hidden form to render either the requested, reason_required, or denied/canceled/timed_out state.
| @@ -0,0 +1,27 @@ | |||
| json.id guard_session.id | |||
There was a problem hiding this comment.
This view is used when polling for the approved/denied/timed out/canceled state.
| </div> | ||
| <div id="cased-logged-out" class="<%= 'hidden' if cased_authorization? %>"> | ||
| <div class="bg-white py-8 px-4 shadow sm:rounded-lg sm:px-10"> | ||
| <%= link_to 'Sign in to Cased', "#{Cased.config.url}/login/connect/#{Cased.config.guard_application_key}?return_to=#{cased.authorizations_url}", id: 'cased-authenticate', class: 'w-full flex justify-center py-2 px-4 border border-transparent rounded-md shadow-sm text-sm font-medium text-white bg-gray-600 hover:bg-gray-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-gray-500' %> |
There was a problem hiding this comment.
This URL ends up looking like:
https://app.cased.com/login/connect/guard_application_1234?return_to=https://admin.application.com/cased/authorizations/callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up
cased-railswith our Cased CLI approval flow. It includes support for authenticating with Cased, reason being required, session not approved, timed out, or canceled. If the application is configured to record sessions,rails consolewill record playback for non-development or test environments (configurable of course).