Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special output format for commands #198

Closed
alinex opened this issue May 11, 2017 · 3 comments · Fixed by #512
Closed

Special output format for commands #198

alinex opened this issue May 11, 2017 · 3 comments · Fixed by #512
Milestone

Comments

@alinex
Copy link

alinex commented May 11, 2017

It's great but I would like to better visually recognize which output lines are the called command and which are the command's output.

So I would like to prefix all command lines with $ (dollar and space) and maybe format this lines in bold yellow in the console.

@casey casey added this to the 1.0 milestone May 13, 2017
@casey
Copy link
Owner

casey commented May 13, 2017

Hi, Alexander! Thanks for the feedback!

I'm hesitant to prefix command lines with text, since it makes it harder to copy and paste them. Also, yellow is traditionally used to indicate warnings.

I actually recently added a--highlight flag, which prints commands in bold, which should render as brighter and/or bold on most terminals. Could you try the --highlight flag? I'm curious if you think it's visible enough. I would definitely consider making --highlight the default.

@casey casey modified the milestones: 1.0, eventually Apr 17, 2019
@casey
Copy link
Owner

casey commented Apr 30, 2019

I think that making --highlight the default behavior might be a good idea, and I'm interested in what other people think pro and con.

@casey casey modified the milestones: eventually, soon, 1.0 Nov 7, 2019
@casey casey closed this as completed in #512 Nov 7, 2019
@casey
Copy link
Owner

casey commented Nov 7, 2019

I think --highlight is a good default, so I changed it in #512. I also added --no-highlight, so the old behavior can be recovered.

@casey casey reopened this Nov 7, 2019
@casey casey closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants