Merge upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to inputManager.js was introduced to fix bug 518735. See commit 7a4fd80. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Fix the dependency path to languageServerRegistry.js Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
This does not include the necessary changes to make the LSP's CompletionItem's additionalTextEdits work. The current code in utils.js uses a property named additionalEdits which conflicts with a property that was created for people extending Orion to add additional text edits to a completion proposal. See bug 439272 and bug 527206 comment 14 for more details. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Ensure that we can retrieve hover information from MarkedStrings. Signed-off-by: Remy Suen <remy.suen@gmail.com>
The proposals from a language server were all being set with an escapePosition field. These were always defined as being the length of the proposal's text and the code would later perform offset calculations based on the CompletionItem's textEdit object. However, if a CompletionItem did not have a textEdit defined, the escape position would be completely off as it would be relative from zero instead of from the content that was being replaced by the proposal. The fix is to remove the property from proposals created from CompletionItems that don't have a textEdit. This will allow Orion to calculate and adjust itself to the escape position based on the replaced text. Signed-off-by: Remy Suen <remy.suen@gmail.com>
…-ids/web-ide-issues#914
…lchains) org-ids/web-ide-issues#947
… is not correctly set
…broke menubar menuitems.
…-console org-ids/web-ide-issues#1001
* initial * re-introduce response-time
…showing keys for Emacs or vi
… auth type in multi-tenant mode (#305)
… enter in text field (#307)
Exception /gitapi/tree API (from orion-monitor channel) org-ids/web-ide-issues#950
…on to look up a user
Show message when authentication is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.