Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dependencies #20

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@adrw
Copy link
Collaborator

adrw commented Nov 1, 2019

  • Bump Misk to public 0.8.0
  • Remove Square URLs
  • Move protos to respective clients
  • Use Wire Gradle Plugin
@adrw adrw force-pushed the adrw:adrw/20191101.miskBump branch 5 times, most recently from 882875c to c7e8c7f Nov 1, 2019
@@ -31,7 +32,8 @@ jobs:
java:
machine:
image: circleci/classic:latest
parallelism: 2
parallelism: 1
working_directory: ~/barber

This comment has been minimized.

Copy link
@shellderp

shellderp Nov 1, 2019

Collaborator

s/barber/backfila/

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

Fixed in #22, will rebase once it lands

"miskSlack": "com.squareup.misk:misk-slack:2019.09.23-1569250868-5144703c",
"miskTesting": "com.squareup.misk:misk-testing:2019.09.23-1569250868-5144703c",
"miskZipkin": "com.squareup.misk:misk-zipkin:2019.09.23-1569250868-5144703c",
"misk": "com.squareup.misk:misk:0.8.0",

This comment has been minimized.

Copy link
@shellderp

shellderp Nov 1, 2019

Collaborator

new misk woo!

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

I do it for the fans

@adrw adrw force-pushed the adrw:adrw/20191101.miskBump branch 2 times, most recently from b846293 to 30f3e54 Nov 1, 2019
@adrw

This comment has been minimized.

Copy link
Collaborator Author

adrw commented Nov 1, 2019

@shellderp Can you look at the java build failure WRT invalid default value for 'lease_expires_at'? Not sure whether there is some part of the code or CircleCI MySql setup I'm missing that has this working locally but not in CI.

Alternatively, could land this PR since it works locally and fix CircleCI in a follow up?

* Bump Misk to public `0.8.0`
* Remove Square URLs
* Move protos to respective clients
* Use Wire Gradle Plugin
@adrw adrw force-pushed the adrw:adrw/20191101.miskBump branch from 30f3e54 to 97e5975 Nov 1, 2019
@shellderp

This comment has been minimized.

Copy link
Collaborator

shellderp commented Nov 1, 2019

@shellderp Can you look at the java build failure WRT invalid default value for 'lease_expires_at'? Not sure whether there is some part of the code or CircleCI MySql setup I'm missing that has this working locally but not in CI.

Alternatively, could land this PR since it works locally and fix CircleCI in a follow up?

weird I'll take a look tonight. Seems fine to merge since this is a migration already applied in production.. what version of mysql is cash using in prod?

edit: likely some mysql setting like strict mode is different from kochiku, can you find the mysql settings used in kochiku?

@adrw

This comment has been minimized.

Copy link
Collaborator Author

adrw commented Nov 1, 2019

I'll land this to unblock some other work I'm doing on cash-backfila and follow up with a fix once I understand Kochiku MySql settings better. Filed an issue here #23

@adrw adrw merged commit 24a8f99 into cashapp:master Nov 1, 2019
2 of 3 checks passed
2 of 3 checks passed
ci/circleci: java Your tests failed on CircleCI
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.