Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mkdocs.yml and fix CircleCI #22

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@adrw
Copy link
Collaborator

adrw commented Nov 1, 2019

  • Docs build requires it, forgot to copy in the docs site addition
@adrw adrw force-pushed the adrw:adrw/20191101.docs2 branch from 38dcdf9 to 9147106 Nov 1, 2019
mkdocs.yml Outdated
theme:
name: 'material'
favicon: img/favicon.ico
logo: img/cashapp.png

This comment has been minimized.

Copy link
@mpawliszyn

mpawliszyn Nov 1, 2019

Collaborator

backfila.png?

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

Nice, will add 👍

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

I'll do this in a follow up, better to land this and unbreak CircleCI

This comment has been minimized.

Copy link
@mpawliszyn

mpawliszyn Nov 1, 2019

Collaborator

🤔

- 'Overview': index.md
- '0.x API':
- 'client': 0.x/client/index.md
- 'client-service': 0.x/client-service/index.md

This comment has been minimized.

Copy link
@mpawliszyn

mpawliszyn Nov 1, 2019

Collaborator

Are these all right?

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

Yes, they match the Gradle subproject names (which could be changed later to make it clearer ie. backfila-client, backfila-client-service, backfila-service)

This comment has been minimized.

Copy link
@mpawliszyn

mpawliszyn Nov 1, 2019

Collaborator

ACK

repo_name: Backfila
repo_url: https://github.com/cashapp/backfila
site_description: "Backfila: Service that manages backfill state, calling into other services to do batched work"
site_author: Square, Inc.

This comment has been minimized.

Copy link
@mpawliszyn

mpawliszyn Nov 1, 2019

Collaborator

Cashapp?

This comment has been minimized.

Copy link
@adrw

adrw Nov 1, 2019

Author Collaborator

We still use Square corporate name on all open source legal for now

@adrw adrw force-pushed the adrw:adrw/20191101.docs2 branch from 9147106 to e7e704d Nov 1, 2019
@adrw adrw changed the title Add mkdocs.yml Add mkdocs.yml and fix CircleCI Nov 1, 2019
@adrw adrw mentioned this pull request Nov 1, 2019
@adrw adrw force-pushed the adrw:adrw/20191101.docs2 branch from e7e704d to 52a32f9 Nov 1, 2019
* Docs build requires it, forgot to copy in the docs site addition
@adrw adrw force-pushed the adrw:adrw/20191101.docs2 branch from 52a32f9 to 650c1e7 Nov 1, 2019
Copy link
Collaborator

mpawliszyn left a comment

Fix CI

@adrw adrw merged commit b66a527 into cashapp:master Nov 1, 2019
1 of 3 checks passed
1 of 3 checks passed
ci/circleci: docs Your tests failed on CircleCI
Details
ci/circleci: java Your tests failed on CircleCI
Details
ci/circleci: node Your tests passed on CircleCI!
Details
@shellderp

This comment has been minimized.

Copy link
Collaborator

shellderp commented Nov 1, 2019

lg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.