Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfila web UI: navbar color reflects environment #45

Open
wants to merge 1 commit into
base: master
from

Conversation

@zcross
Copy link
Collaborator

zcross commented Jan 6, 2020

Fixes #16

I noticed this using backfila. IMO, visual cues about the current environment can help reduce the risk of operational tasks, so this is pretty important.

That said, I kept the specific shade of red that we must've thought was nice when initially writing this.

Meta: The current README's instructions reference a nonexistent BackfilaService.kt and there are some DI exceptions related to the web actions when trying to run BackfilaDevelopmentService.kt

@shellderp

This comment has been minimized.

Copy link
Collaborator

shellderp commented Jan 6, 2020

does this still set the background to red/something else in staging? or is it foreground now?

meta: Yeah I have a fix locally for the dev stuff, will send a PR eventually. I think if you load cash-backfila and backfila in polyrepo you can run the CashBackfilaService instead

@zcross

This comment has been minimized.

Copy link
Collaborator Author

zcross commented Jan 7, 2020

No, this should only make production red. Staging should be green!

export const backfilaTheme: ITheme = {
...defaultTheme,
environmentToColor: environmentToColor(environmentColorLookup),
navbarBackground: backfilaRed

This comment has been minimized.

Copy link
@adrw

adrw Jan 8, 2020

Collaborator

Have you tested this locally? navbarBackground currently applies across all environments so this change would remove the red from the navbar even in production. Making navbar background environment specific is easily possible but would require associated Misk-Web changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.