Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 0.1.0 #10

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@adrw
Copy link
Collaborator

commented Jul 16, 2019

  • Paired with @swankjesse to prepare Barber for first release: 0.1.0.
  • Renamed subproject from client to barber
  • Added a mkdocs docs site that includes dokka KDocs similar to https://square.github.io/okhttp/
  • Updated releasing.md with more thorough instructions on preparation work required to publish to Sonatype
@adrw adrw force-pushed the adrw:adrw/20190716.release branch 2 times, most recently from 007d865 to 7c7d67f Jul 16, 2019
@@ -176,7 +176,8 @@ class BarbershopBuilder : Barbershop.Builder {
// Pre-compile Mustache templates
val documentDataFields: MutableMap<String, Mustache?> =
documentTemplate.fields.mapValues {
mustacheFactory.compile(StringReader(it.value), it.value)
val mustache = mustacheFactory.compile(StringReader(it.value), it.value)
mustache

This comment has been minimized.

Copy link
@wesleyk

wesleyk Jul 16, 2019

Collaborator

why this change?

This comment has been minimized.

Copy link
@adrw

adrw Jul 16, 2019

Author Collaborator

Thanks, will revert. Had set the variable for debugging during brief API review.

p.tasks.dokka {
reportUndocumented = false
skipDeprecated = true
jdkVersion = 8

This comment has been minimized.

Copy link
@wesleyk

wesleyk Jul 16, 2019

Collaborator

why not 11?

This comment has been minimized.

Copy link
@adrw

adrw Jul 16, 2019

Author Collaborator

@swankjesse : 11 doesn't give us much at this point over 8 with respect to the docs

This comment has been minimized.

Copy link
@swankjesse

swankjesse Jul 16, 2019

Collaborator

11 is more strict about some things and I’m not sure whether it works or not. Worth trying if there’s anything from 11 we need.

@adrw adrw force-pushed the adrw:adrw/20190716.release branch from 7c7d67f to e821707 Jul 16, 2019
@adrw adrw merged commit 6c408a8 into cashapp:master Jul 16, 2019
1 check passed
1 check passed
ci/circleci: java Your tests passed on CircleCI!
Details
Copy link
Collaborator

left a comment

LGTM!

p.tasks.dokka {
reportUndocumented = false
skipDeprecated = true
jdkVersion = 8

This comment has been minimized.

Copy link
@swankjesse

swankjesse Jul 16, 2019

Collaborator

11 is more strict about some things and I’m not sure whether it works or not. Worth trying if there’s anything from 11 we need.

@@ -0,0 +1,48 @@
@font-face {

This comment has been minimized.

Copy link
@swankjesse

swankjesse Jul 16, 2019

Collaborator

nice

@adrw adrw referenced this pull request Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.