Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BarbershopBuilderTest into Error and Warning #22

Closed
wants to merge 1 commit into from

Conversation

@adrw
Copy link
Collaborator

commented Aug 1, 2019

No description provided.

@wesleyk

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

IMO I find it confusing to have one class lead to many test files.

@adrw

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 1, 2019

Spoke offline and I agree

@adrw adrw closed this Aug 1, 2019

@wesleyk

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

Some additional reasoning (discussed offline): a good scenario would be around refactors and how you might end up having to move test cases between files. Say, if a warning becomes an error: it seems pretty awkward to have to move a block of code from one test to another. Or worse yet, the test becomes stale and now the test class names are misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.