Pause Gradle initialisation until Hermit has installed all packages. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
force-pushed
the
juho/post-startup
branch
2 times, most recently
from
e5ba02f
to
e92c869
Compare
alecthomas
approved these changes
May 12, 2022
| Enabled, | ||
| Failed | ||
| Disabled, // Hermit is not in use | ||
| Installing, // Installing Hermit packages to the system |
alecthomas
reviewed
May 12, 2022
src/main/kotlin/com/squareup/cash/hermit/gradle/HermitGradleExecutionAware.kt
Outdated
Show resolved
Hide resolved
jvmakine
force-pushed
the
juho/post-startup
branch
from
e92c869
to
eb14725
Compare
This prevents errors of Invalid JDK when a user opens a project referring to a hermit managed JDK that is not on disk yet
jvmakine
force-pushed
the
juho/post-startup
branch
from
eb14725
to
05979b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents errors of Invalid JDK when a user opens a project referring to a hermit managed JDK that is not on disk yet.
This also adds a new hermit status: installing
Closes #33
GradleExecutionAwares are run in a single thread sequentially. So, we can just register one before the main initialiser that verifies the Gradle JVM, and pause the thread until Hermit has finished running.This API was only introduced in
2021.2.1release released on 7/2021. So, unfortunately, we must drop updates to older IntelliJ versions to enable this.