Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make menu hamburger button overrideable / optional #572

Closed
adrw opened this issue Sep 10, 2019 · 0 comments · Fixed by #574

Comments

@adrw
Copy link
Collaborator

commented Sep 10, 2019

For services that use the Navbar:

  • Give the option to pass in own icons for open/closed
  • Allow turning off/on if the icon/menu appears at all

@adrw adrw added the @misk/core label Sep 10, 2019

adrw added a commit to adrw/misk-web that referenced this issue Sep 10, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES cashapp#572]
adrw added a commit to adrw/misk-web that referenced this issue Sep 10, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES cashapp#572]
adrw added a commit to adrw/misk-web that referenced this issue Sep 10, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES cashapp#572]
adrw added a commit to adrw/misk-web that referenced this issue Sep 10, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES cashapp#572]
adrw added a commit to adrw/misk-web that referenced this issue Sep 11, 2019
Add props to Navbar to customize MenuButton
* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES cashapp#572]

@adrw adrw closed this in #574 Sep 11, 2019

adrw added a commit that referenced this issue Sep 11, 2019
Add props to Navbar to customize MenuButton (#574)
* Add props to Navbar to customize MenuButton

* Add to `@misk/test` library "@testing-library/dom" for easier tests
* New props added to Navbar to customize MenuButton

```
menuIcon?: IconName | JSX.Element | string
menuOpenIcon?: IconName | JSX.Element | string
menuButtonAsLink?: boolean
menuShowButton?: boolean
```

* [CLOSES #572]

* [RELEASE] 0.1.18-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.