Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to CircleCI #320

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Collaborator

commented Jun 6, 2019

No description provided.

@@ -15,6 +21,10 @@ jobs:
- run:
name: Installing...
command: node common/scripts/install-run-rush.js install
- save_cache:

This comment has been minimized.

Copy link
@jaredwindover

jaredwindover Jun 6, 2019

Collaborator

Does this happen regardless of whether or not the shrinkwrap.yaml has changed?

This comment has been minimized.

Copy link
@adrw

adrw Jun 6, 2019

Author Collaborator

My understanding is that it saves every time.

This comment has been minimized.

Copy link
@jaredwindover

jaredwindover Jun 6, 2019

Collaborator

Do we care/can we avoid that when there's no update?

This comment has been minimized.

Copy link
@jaredwindover

jaredwindover Jun 6, 2019

Collaborator

Otherwise lgtm

This comment has been minimized.

Copy link
@adrw

adrw Jun 6, 2019

Author Collaborator

Fair question, if it net doesn't improves build times I'll revert. Not sure if that type of logic can be added or it may already be implicitly happening if there's a key match on save.

@adrw adrw merged commit 1d90d30 into cashapp:master Jun 6, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details

adrw added a commit to adrw/misk-web that referenced this pull request Jun 6, 2019

adrw added a commit that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.