Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second Node CI task to pass on looser update (vs install) #324

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@adrw
Copy link
Collaborator

commented Jun 6, 2019

  • Human made PRs with changed NPM versions should run rush update to update the shrinkwrap.yaml
  • Renovate and bot made PRs won't have run rush update but should still pass CI
  • In Github the new nodeUpdate can be a required check, while nodeInstall can be left optional but be a sign to humans that their PRs should be fixed before merging
Add second Node CI task to pass on looser update (vs install)
* Human made PRs with changed NPM versions should run `rush update` to update the shrinkwrap.yaml
* Renovate and bot made PRs won't have run `rush update` but should still pass CI
* In Github the new `nodeUpdate` can be a required check, while `nodeInstall` can be left optional but be a sign to humans that their PRs should be fixed before merging
@adrw

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 6, 2019

Spoke offline and found this wouldn't work since master would break as a result of the unchecked in updated shrinkwrap.yaml.

@adrw adrw closed this Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.