Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stump out guide sections for Building a Tab & Integrating with Misk #423

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@adrw
Copy link
Collaborator

commented Aug 9, 2019

No description provided.

@adrw adrw requested a review from aashnisshah Aug 9, 2019

@@ -0,0 +1,3 @@
# Admin Dashboard

- Review steps for adding a custom tab to dashboard (ie: `$ miskweb misk`)

This comment has been minimized.

Copy link
@aashnisshah

aashnisshah Aug 9, 2019

Collaborator

Not for this PR, but we should definitely have an explanation of the difference between admin dashboard and a misk tab


Review quickly that multiple tabs should have different ports, can be under the same dashboard menu category.

## Shared Code between Tabs

This comment has been minimized.

Copy link
@aashnisshah

aashnisshah Aug 9, 2019

Collaborator

Is this meant to be here, or on the 6-shared-code-between-tabs below?

@adrw adrw force-pushed the adrw:adrw/20190809.docs branch from a4f0122 to 3c1d090 Aug 9, 2019

@adrw adrw merged commit 0a04af9 into cashapp:master Aug 9, 2019

3 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.