Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will fix the deprecation warning for yargs #554

Closed
wants to merge 1 commit into from

Conversation

@codemile
Copy link

commented Sep 3, 2019

Fixes this issue: #520

@@ -1,6 +1,6 @@
#!/usr/bin/env node

import * as yargs from "yargs"
import yargs = require('yargs');

This comment has been minimized.

Copy link
@adrw

adrw Sep 5, 2019

Collaborator
  1. Could you run linting please? (should fix no semi-colons and double quote marks only) $npm run-script lint
  2. In my tests, it looks like changing the import to import yargs from "yargs" is sufficient. Could you do that instead?
  3. Could you also update the import statement in src/utils/handleCommand.ts?

Thanks for contributing!

@adrw

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2019

Thanks for contributing, fix was merged in #594 ! 🎉

@adrw adrw closed this Sep 13, 2019

@codemile

This comment has been minimized.

Copy link
Author

commented Sep 13, 2019

@adrw I'm so sorry. I was going to get back to you on this, but I commented on yargs about this problem and they fixed it.

They've removed the warning message, and it'll be in the next release.

yargs/yargs@bb0eb52#diff-168726dbe96b3ce427e7fedce31bb0bc

I don't think there is any harm in this for now. This is what I do on my project, but it's good to know that they removed the warning. I don't think it was a good way to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.