Skip to content
Permalink
Browse files

Make HTTP/2 opt-in, not opt-out

Waiting on graceful shutdown in Jetty
eclipse/jetty.project#2788
  • Loading branch information...
swankjesse committed Sep 10, 2019
1 parent 49258e0 commit e0117565f66ec7769b674c2f21d023e6a5afd02a
@@ -10,7 +10,9 @@ import javax.inject.Named
/** A module that runs a Misk gRPC server: Wire protos and a Jetty backend. */
class RouteGuideMiskServiceModule : KAbstractModule() {
override fun configure() {
install(WebTestingModule())
install(WebTestingModule(webConfig = WebTestingModule.TESTING_WEB_CONFIG.copy(
http2 = true
)))
install(WebActionModule.create<GetFeatureGrpcAction>())
install(WebActionModule.create<RouteChatGrpcAction>())
}
@@ -18,7 +18,7 @@ data class WebConfig(
val ssl: WebSslConfig? = null,

/** HTTP/2 support is currently opt-in because we can't load balance it dynamically. */
val http2: Boolean = true,
val http2: Boolean = false,

/** Number of NIO selector threads. */
val selectors: Int? = null,
@@ -108,7 +108,9 @@ class GrpcConnectivityTest {

class TestModule : KAbstractModule() {
override fun configure() {
install(WebTestingModule())
install(WebTestingModule(webConfig = WebTestingModule.TESTING_WEB_CONFIG.copy(
http2 = true
)))
install(WebActionModule.create<HelloRpcAction>())
}
}

0 comments on commit e011756

Please sign in to comment.
You can’t perform that action at this time.