Skip to content
Permalink
Branch: master
Commits on Aug 17, 2019
  1. Merge pull request #1158 from cashapp/jwilson.0817.receive_first

    swankjesse committed Aug 17, 2019
    Fix a bug where gRPC couldn't send responses first
  2. Fix a bug where gRPC couldn't send responses first

    swankjesse committed Aug 17, 2019
Commits on Aug 16, 2019
  1. Log org.hibernate at ERROR (#1151)

    maniksurtani committed Aug 16, 2019
Commits on Aug 15, 2019
  1. Merge pull request #1154 from adrw/adrw/20190814.docs

    swankjesse committed Aug 15, 2019
    Add MkDocs Material + Dokka powered docs site
  2. Add MkDocs Material + Dokka powered docs site

    adrw committed Aug 15, 2019
    * Inspired liberally by existing MkDocs sites in OkHttp and Barber
    * MkDocs really chugs generating the site for this many Dokka generated docs so it takes some patience if you want to build the docs site locally (2-5 mins to build instead of near instantly with other repos)
    * There are numerous warnings from MkDocs of dead links in the Dokka generated content. This PR makes no changes to the existing docs in Misk projects. Future PRs should.
    * [CLOSES #1148]
Commits on Aug 14, 2019
  1. Bump Misk-Web 0.1.16-4 (#1150)

    adrw committed Aug 14, 2019
    * Fixes long time error of `Failure to load script /tab_loader.js`
Commits on Aug 13, 2019
  1. Access Vitess using the MySQL driver (#1144)

    tirsen committed Aug 13, 2019
    Adds a new VITESS_MYSQL data source type which accesses Vitess using the
    mysql protocol and the MySQL JDBC driver
Commits on Aug 12, 2019
  1. Remove duplicate authentication logic in WebTab (#1146)

    adrw committed Aug 12, 2019
  2. [CLOSES #1129] DashboardTabProvider (#1142)

    adrw committed Aug 12, 2019
    * New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
    * Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
    * Also allows for service tabs to be easily set with service specific Access Annotations
    
    * Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound
Commits on Aug 9, 2019
  1. exclude log4j from transitive dependencies of curator (try again) (#1141

    mightyguava committed Aug 9, 2019
    )
    
    The previous attempt didn't prune everything
  2. exclude log4j from transitive dependencies of docker (#1140)

    mightyguava committed Aug 9, 2019
  3. exclude log4j from transitive dependencies of curator (#1139)

    mightyguava committed Aug 9, 2019
    Don't know if this does what I want. I want misk to not include
    `slf4j-log4j12`, which comes from curator:
    
    ```
     |    +--- org.apache.curator:curator-framework:4.0.1
    |    |    \--- org.apache.curator:curator-client:4.0.1
    |    |         +--- org.apache.zookeeper:zookeeper:3.5.3-beta -> 3.5.4-beta
    |    |         |    +--- org.slf4j:slf4j-api:1.7.25
    |    |         |    +--- org.slf4j:slf4j-log4j12:1.7.25
    ```
    
    I also want any apps that depend on both Misk and Curator, to
    automatically exclude `slf4j-log4j12`, without needing a similar clause
    to what I'm adding here in the app's build.gradle.
Commits on Aug 7, 2019
  1. Merge pull request #1135 from cashapp/sumair/7aug2019/fix_bulk_shard_…

    surrahman committed Aug 7, 2019
    …migrator_ids
    
    Cast ids to misk.hibernate.Id instead of Long in BulkShardMigrator
Commits on Aug 6, 2019
  1. Propogate config changes from DataSourceService (#1134)

    keeferrourke committed Aug 6, 2019
  2. Merge pull request #1133 from cashapp/mgersh-specify-envoy-env-http

    shellderp committed Aug 6, 2019
    Allow specifying env in HttpClientEnvoyConfig
  3. Merge pull request #1132 from cashapp/jwilson.0806.upgrade_wire

    swankjesse committed Aug 6, 2019
    Upgrade to Wire 3.0.0-rc01
  4. Allow specifying env in HttpClientEnvoyConfig

    Michael Gershunovsky
    Michael Gershunovsky committed Aug 6, 2019
    This doesn't change any behavior unless it is specified.
    
    For example backfila will specify `production-jobs` as the env, not `production`
  5. Upgrade to Wire 3.0.0-rc01

    swankjesse committed Aug 6, 2019
    This rearranges several gRPC classes.
  6. Fix TestDatabasePool (#1131)

    keeferrourke committed Aug 6, 2019
    TestDatabasePool was:
    
     1. Catching the wrong exception (`PersistenceException` instead of
        `SQLException`)
     2. Not releasing database names for re-use to the correct pool (instead
        they would be released to a brand new pool)
    
    This change fixes both of these issues and adds an integration test that
    works on a real MySQL database, and a regression test for database name
    releases.
Commits on Aug 5, 2019
Commits on Aug 2, 2019
  1. Fixes and speed ups for Vitess test running (#1126)

    tirsen committed Aug 2, 2019
    * Only pull Vitess image if it's not already pulled
    
    * Remove Vitess cluster container that is not running
    
    * Log the list of shards returned by Vitess
    
    * Work around the issue that sometimes SHOW VITESS_SHARDS returns nothing
    
    * Fix compilation error
    
    * Catch the JDBC error
Commits on Aug 1, 2019
  1. Make misk.Id implement Comparable (#1127)

    river-jade authored and jjestrel committed Aug 1, 2019
  2. Merge pull request #1125 from cashapp/jwilson.0730.reflect

    swankjesse committed Aug 1, 2019
    Reflection utilities so we can handle annotations on supertypes.
  3. Reflection utilities so we can handle annotations on supertypes.

    swankjesse committed Jul 31, 2019
    I want to do @WireRpc on supertypes but that PR isn't ready yet.
  4. Pool database names for tests (#1123)

    keeferrourke committed Aug 1, 2019
    This change introduces a `DatabasePool` which is used by `DataSourceService`
    to obtain (and under test, allocate) database names.
    
    In production, this changes nothing; we will always use the database
    that was specified by the config.
    
    In test, each `MiskTest` annotated test will operate on a special
    database called `database_yyyyMMdd_s`, where `database` is the name
    specified by the `DataSourceConfig.database` property, `yyyyMMdd` is the
    current date, and `s` is a sequence number.
    
    e.g. If two tests for a cinema service are running in parallel and they
    request access to the same database, then the first test will use a
    database called `movies_20190731_1`, and the second test will use a
    database called `movies_20190731_2`. These databases are released for
    usage by other tests that run afterwards, should they require them.
    
    This feature can be opted into by configuring the `HibernateModule` as
    follows in a testing module:
    
    ```kotlin
    install(HibernateModule(Movies::class, config, SHARED_TEST_DATABASE_POOL))
    ```
Commits on Jul 31, 2019
  1. Merge pull request #1120 from cashapp/jwilson.0725.stale_connections

    swankjesse committed Jul 31, 2019
    Track whether the connection changed on retries
Commits on Jul 30, 2019
  1. Support graceful shutdown for real this time (#1124)

    jjestrel committed Jul 30, 2019
Commits on Jul 28, 2019
  1. Exclude junit4 so it stops getting accidentally imported (#1122)

    jjestrel committed Jul 28, 2019
Commits on Jul 26, 2019
  1. Track whether the connection changed on retries

    swankjesse committed Jul 26, 2019
    We've had bugs where MySQL appears to be returning stale data. The
    goal here is to see if this problem is isolated to reused connections.
Commits on Jul 25, 2019
  1. Log redacted caller in AccessInterceptor (#1117)

    keeferrourke committed Jul 25, 2019
  2. Merge pull request #1113 from cashapp/frojas/misk-client-record-timeouts

    frojasg committed Jul 25, 2019
    [misk.client] Records metrics for timeout requests
Commits on Jul 24, 2019
  1. Merge pull request #1116 from cashapp/jwilson.0724.delay

    swankjesse committed Jul 24, 2019
    Print the delay when retrying
Older
You can’t perform that action at this time.