Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set authentication in AdminDashboardTab bindings for Config and Web-Actions tab from the bound AdminDashboardAccess #1129

Closed
adrw opened this issue Aug 2, 2019 · 0 comments

Comments

@adrw
Copy link
Collaborator

commented Aug 2, 2019

No description provided.

@adrw adrw added the frontend label Aug 2, 2019

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations
* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 9, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabAuthenticatedProvider
* New pattern of multibinding tabs to a DashboardTabAuthenticatedProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabProvider
* New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabProvider
* New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabProvider
* New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabProvider
* New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

adrw added a commit to adrw/misk that referenced this issue Aug 12, 2019

[CLOSES cashapp#1129] DashboardTabProvider
* New pattern of multibinding tabs to a DashboardTabProvider along with an AccessAnnotation
* Allows for Misk tabs to be set with the authentication from the multibound `AdminDashboardAccess` access annotation
* Also allows for service tabs to be easily set with service specific Access Annotations

* Fixes small bug in Loader tab where dashboard doesn't load when no tabs are bound

@adrw adrw closed this in 9621367 Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.