Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Enum types in Web Actions Tab #933

Closed
adrw opened this issue Apr 18, 2019 · 0 comments

Comments

@adrw
Copy link
Collaborator

commented Apr 18, 2019

Existing response returns the the class (ie. "com.squareup.protos.cash.raven.api.SmsDeliveryType") as the type for a field. But that enum class definition isn't included so it can't be resolved. Enum class definitions will need to be parsed and included in the WebActionMetadataAction response in a way that Web Actions tab can use them to present a <select> field.

WebActionMetadataAction Desired Response

{
 ...
 "types": {
        "com.squareup.protos.cash.raven.api.SendSmsNotificationRequest": {
          "fields": [
            {
              "name": "token",
              "type": "String",
              "repeated": false
            },
            ...
            {
              "name": "sms_delivery_type",
              "type": "com.squareup.protos.cash.raven.api.SmsDeliveryType",
              "repeated": false
            },
           ...
         ]
       },
       "com.squareup.protos.cash.raven.api.SmsDeliveryType": [
           "SMS", "VOICE"
         ]
   }
...
}
@adrw adrw self-assigned this Apr 18, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
adrw added a commit to adrw/misk that referenced this issue Oct 9, 2019
@adrw adrw closed this in 3f28caf Oct 9, 2019
yan pushed a commit that referenced this issue Oct 17, 2019
* master:
  Support multiple dashboards with new DashboardMetadataAction (#1231)
  [Misk #1119] Support for count queries in Query abstraction
  Add friendly KT requireBinding() method (#1240)
  Make metrics required in RepeatedTaskQueue (#1229)
  Add support PostLoad and SaveUpdate listeners
  RepeatedTaskQueue metrics need to be a Singleton (#1226)
  Allow a configurable num_of_parallel tasks (#1225)
  Add count/latency metric for PendingTasks (#1224)
  http metrics do not pre-aggregate (#1223)
  Support Transacter#replicaRead on MySQL
  [CLOSES #933] Add enum support to web-actions tab form (#1220)
  Bump Misk-Web 0.1.22 (#1219)
  Run TransacterTest on all supported datasource
  Update to Wire 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.