Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split FormValueParameterExtractorFactory into 3 parts. #1040

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@swankjesse
Copy link
Collaborator

commented Jun 6, 2019

FormValueParameterExtractorFactory: glue to move form data into Action parameters
FormData: a model of form data
FormAdapter: glue to turn form data into an instance of a Kotlin class

Previously these were all in FormValueParameterExtractorFactory and that felt awkward.

Split FormValueParameterExtractorFactory into 3 parts.
FormValueParameterExtractorFactory: glue to move form data into Action parameters
FormData: a model of form data
FormAdapter: glue to turn form data into an instance of a Kotlin class

Previously these were all in FormValueParameterExtractorFactory and that felt awkward.
@adrw

adrw approved these changes Jun 6, 2019

?: name?.toLowerCase()
?: throw IllegalStateException("cannot introspect parameter name")

// TODO(jwilson): explode if no converter is found. As is we just replace values with nulls.

This comment has been minimized.

Copy link
@adrw

adrw Jun 6, 2019

Collaborator

Should this be addressed in this PR?

This comment has been minimized.

Copy link
@swankjesse

swankjesse Jun 6, 2019

Author Collaborator

Nah, gotta follow rule #1. Never combine refactorings with behavior changes.

@swankjesse swankjesse merged commit be5c91e into master Jun 6, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details

@oldergod oldergod deleted the jwilson.0606.forms branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.