Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and apply spotless + ktlint #1082

Merged
merged 1 commit into from Jun 26, 2019

Conversation

@adrw
Copy link
Collaborator

commented Jun 26, 2019

No description provided.

ktlint(dep.ktlintVersion).userData(['indent_size': '2', 'continuation_indent_size' : '2'])
}
}
compileKotlin.dependsOn 'spotlessKotlinApply'

This comment has been minimized.

Copy link
@wesleyk

wesleyk Jun 26, 2019

Collaborator

do we want to incur this with every compile?

This comment has been minimized.

Copy link
@adrw

adrw Jun 26, 2019

Author Collaborator

It seems to be a trivial addition (< 1 sec) even on a project as large as Misk. If we want it to be moved to another stage of the lifecycle, it should exist at minimum as a pre-commit hook so that committed code has been linted and fixed.

This comment has been minimized.

Copy link
@wesleyk

wesleyk Jun 26, 2019

Collaborator

just want to make sure it's not too much of a surprise to developers. How does it look in intellij?

This comment has been minimized.

Copy link
@adrw

adrw Jun 26, 2019

Author Collaborator

For the most part it only appears as an extra line in the tasks blob in Gradle output. If it gets stuck on any fix, the error makes clear that it is a linting error and clearly states the problem and solution.

@adrw adrw merged commit 1f1b09a into cashapp:master Jun 26, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.