Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate errors for db connection and ping #1112

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@keeferrourke
Copy link
Collaborator

commented Jul 23, 2019

This change separates the error cases for failing to obtain a db connection and failing to ping the database in PingDatabaseService. This should make diagnosing db errors easier.

@keeferrourke keeferrourke requested a review from swankjesse Jul 23, 2019

@keeferrourke keeferrourke force-pushed the keefer/0723-more-granular-db-connection-errors branch from a4c3219 to 73b1b3f Jul 23, 2019

@keeferrourke keeferrourke merged commit aa9d7fc into master Jul 23, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.