Track whether the connection changed on retries #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acostama
reviewed
Jul 26, 2019
| return transactionInternal(block) | ||
| val result = transactionInternal(block) | ||
|
|
||
| if (attempt > 0) { |
There was a problem hiding this comment.
Seems like this is always true
acostama
approved these changes
Jul 26, 2019
We've had bugs where MySQL appears to be returning stale data. The goal here is to see if this problem is isolated to reused connections.
swankjesse
force-pushed
the
jwilson.0725.stale_connections
branch
from
128b16b
to
49e015a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had bugs where MySQL appears to be returning stale data. The
goal here is to see if this problem is isolated to reused connections.