Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude log4j from transitive dependencies of curator (try again) #1141

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@mightyguava
Copy link
Collaborator

commented Aug 9, 2019

The previous attempt didn't prune everything #1139

exclude log4j from transitive dependencies of curator (try again)
The previous attempt didn't prune everything

testCompile dep.docker
testCompile dep.junitApi
testCompile dep.zookeeper
testCompile(dep.zookeeper) {

This comment has been minimized.

Copy link
@keeferrourke

keeferrourke Aug 9, 2019

Collaborator

testCompile includes the configurations from compile does it not?

This comment has been minimized.

Copy link
@mightyguava

mightyguava Aug 9, 2019

Author Collaborator

the excludes don't propagate. Anywhere you explicitly depend on zookeeper or curator, you need to exclude this package

This comment has been minimized.

Copy link
@mightyguava

mightyguava Aug 9, 2019

Author Collaborator

so, I'm still not totally sure this'll work, but hopeful

@mightyguava mightyguava merged commit e52af96 into master Aug 9, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details

@mightyguava mightyguava deleted the yunchi/ban-log4j-zk branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.