Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate authentication logic in WebTab #1146

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@adrw
Copy link
Collaborator

commented Aug 12, 2019

@adrw adrw requested a review from wesleyk Aug 12, 2019

@@ -101,5 +90,16 @@ class AccessInterceptor private constructor(

companion object {
val logger = getLogger<AccessInterceptor>()

internal fun isAllowed(caller: MiskCaller, allowedCapabilities: Set<String>, allowedServices: Set<String>): Boolean {

This comment has been minimized.

Copy link
@wesleyk

wesleyk Aug 12, 2019

Collaborator

how do you feel about this being a method on MiskCaller?

This comment has been minimized.

Copy link
@adrw

adrw Aug 12, 2019

Author Collaborator

I think that'd make sense! 👍

@adrw adrw force-pushed the adrw:adrw/20190812.reuse branch 4 times, most recently from 32d8071 to 561a8e8 Aug 12, 2019

@adrw adrw force-pushed the adrw:adrw/20190812.reuse branch from 561a8e8 to d5e0fba Aug 12, 2019

@adrw adrw merged commit dd8ed62 into cashapp:master Aug 12, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.