Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog: inject trace/span ids into MDC #1188

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@mightyguava
Copy link
Collaborator

commented Sep 6, 2019

No description provided.

@mightyguava mightyguava requested a review from wesleyk Sep 6, 2019

@wesleyk

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

interesting, should we request upstream for them to give us this for free?

@wesleyk
wesleyk approved these changes Sep 6, 2019
@wesleyk

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

interesting, should we request upstream for them to give us this for free?

err actually saw your other PR where we disable automated injection? Is this what we're doing instead?

@mightyguava

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

err actually saw your other PR where we disable automated injection? Is this what we're doing instead?

Yeah, they hard-code dd.span_id and dd.trace_id. We don't want the dd prefix. I think they have it to enable directly linking from tracing to logs, but we don't use datadog logs so it doesn't matter.

Could probably ask them to turn it into an option, but it's not really worth the effort to me.

@mightyguava

This comment has been minimized.

@mightyguava mightyguava merged commit 9713983 into master Sep 6, 2019

3 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details

@mightyguava mightyguava deleted the yunchi/datadog branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.