Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span context to all queries when using VITESS over MySQL #1200

Merged
merged 2 commits into from Sep 19, 2019

Conversation

@systay
Copy link
Collaborator

commented Sep 16, 2019

No description provided.

Signed-off-by: Andres Taylor <antaylor@squareup.com>
@systay systay requested review from tirsen and mightyguava Sep 16, 2019
@systay

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 16, 2019

This time I'm only using datadog for testing.

@@ -25,6 +25,7 @@ dependencies {
compile dep.openTracingUtil
compile dep.openTracingJdbc
compile dep.tracingJaeger
compile dep.openTracingDatadog

This comment has been minimized.

Copy link
@mightyguava

mightyguava Sep 16, 2019

Collaborator

This should be a testCompile

Signed-off-by: Andres Taylor <antaylor@squareup.com>
@systay systay force-pushed the systay:span-context-in-queries branch from 9aa40c1 to 4d52328 Sep 17, 2019
@systay systay merged commit 88d297b into cashapp:master Sep 19, 2019
3 checks passed
3 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.