Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sdk_key to a resource loader path instead of secret #1215

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@mightyguava
Copy link
Collaborator

commented Oct 2, 2019

We need to create the LaunchDarklyConfig programmatically in skim's
wrapper for this module and it's a huge PITA to do this with Secret

We need to create the LaunchDarklyConfig programmatically in skim's
wrapper for this module and it's a huge PITA to do this with `Secret`
@mightyguava mightyguava requested review from wesleyk and AlexSzlavik Oct 2, 2019
@wesleyk
wesleyk approved these changes Oct 2, 2019
@mightyguava mightyguava merged commit 16ebfbe into master Oct 2, 2019
3 checks passed
3 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
@mightyguava mightyguava deleted the yunchi/ld branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.