Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out misk-service module for misk's ServiceManager #1216

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@mightyguava
Copy link
Collaborator

commented Oct 3, 2019

This makes misk.ServiceModule usable in misk-feature-testing. ServiceModule is needed by basically every misk module, so splitting it out will make it easier for us to use it internally in dc.

@mightyguava mightyguava requested review from swankjesse and jjestrel Oct 3, 2019
@mightyguava mightyguava force-pushed the yunchi/ld branch from 70e0056 to 27cefc9 Oct 3, 2019
Copy link
Collaborator

left a comment

stamped but I think ultimately this stuff might live in misk-core or something like that

@mightyguava mightyguava force-pushed the yunchi/ld branch from 27cefc9 to a59612f Oct 3, 2019
@@ -30,7 +30,7 @@ class StatusAction @Inject internal constructor(
val services = serviceManagerProvider.get().servicesByState().values().asList()
val serviceStatus = services.map {
when (it) {
is CoordinatedService -> it.service.javaClass.simpleName to it.state()
is DelegatingService -> it.service.javaClass.simpleName to it.state()

This comment has been minimized.

Copy link
@mightyguava

mightyguava Oct 3, 2019

Author Collaborator

@jjestrel fyi I added a new interface to work around CoordinatedService being internal

This comment has been minimized.

Copy link
@jjestrel

jjestrel Oct 3, 2019

Collaborator

@swankjesse and I spent a lot of time talking about this in a different PR. I think DelegatingService is better than what I tried in my other PR. LGTM

@mightyguava mightyguava merged commit 6b21377 into master Oct 3, 2019
3 checks passed
3 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details
@mightyguava mightyguava deleted the yunchi/ld branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.