Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add validation to feature flag key #1278
Only allow things that look like keys to be passed in to
I'm also not sure we should have this level of validation. Theoretically users should be testing their code and making sure they are passing in the right key. But, evidence shows that this hasn't been happening. The risk of a bug here is high, since we could potentially launch features to the wrong customers, or worse accidentally send PII to the feature flag vendor when we don't mean to.
So I think this validation is a good bad way of preventing mistakes.
ryanhall07 left a comment •
I think this is reasonable, but like you said, it doesn't belong in misk :)
would it really be that much work to add a
Spoke offline. At the moment Franklin can't pull in Misk guice modules for the most part. We'd need to publish a new misk jar and it's not really worth the effort.