Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin and Compose #1549

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Update Kotlin and Compose #1549

merged 2 commits into from
Aug 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 22, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin (source) 2.0.10-1.0.24 -> 2.0.20-1.0.24 age adoption passing confidence
com.google.devtools.ksp:symbol-processing-api (source) 2.0.10-1.0.24 -> 2.0.20-1.0.24 age adoption passing confidence
org.jetbrains.kotlin:compose-compiler-gradle-plugin (source) 2.0.10 -> 2.0.20 age adoption passing confidence
org.jetbrains.kotlin:kotlin-gradle-plugin (source) 2.0.10 -> 2.0.20 age adoption passing confidence
org.jetbrains.kotlin:kotlin-bom (source) 2.0.10 -> 2.0.20 age adoption passing confidence

Release Notes

google/ksp (com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin)

v2.0.20-1.0.24

Compare Source

What's Changed

JetBrains/kotlin (org.jetbrains.kotlin:compose-compiler-gradle-plugin)

v2.0.20


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/kotlin-and-compose branch from 0ad5cec to 3a1ac98 Compare August 22, 2024 21:53
@renovate renovate bot changed the title Update Kotlin and Compose to v2.0.20 Update Kotlin and Compose Aug 22, 2024
@renovate renovate bot force-pushed the renovate/kotlin-and-compose branch 3 times, most recently from f9cafd1 to 66d6f17 Compare August 23, 2024 16:17
@jrodbx
Copy link
Collaborator

jrodbx commented Aug 26, 2024

Looks like this PR is failing because of an issue fixed in Poko 0.17.0.

However, the build bumping to that version fails too, because of:

e: java.util.NoSuchElementException: Array is empty.
	at kotlin.collections.ArraysKt___ArraysKt.single(_Arrays.kt:2847)
> Task :paparazzi:compileKotlin
	at dev.drewhamilton.poko.ir.PokoMembersTransformer.IrValueParameterSymbolImplCompat(PokoMembersTransformer.kt:198)

Possible regression in Poko pre-2.0.20 support, or should these two PRs simply be merged in tandem? @drewhamilton @JakeWharton

@drewhamilton
Copy link

Yeah, Kotlin 2.0.20 requires Poko 0.17.0 and vice-versa. Poko should be updated at the same time as Kotlin in the Renovate config the same way Compose is, since compiler plugin APIs break frequently.

(I tried to keep compatibility with 2.0.0 in this release but it didn't work.)

@jrodbx
Copy link
Collaborator

jrodbx commented Aug 26, 2024

(I tried to keep compatibility with 2.0.0 in this release but it didn't work.)

Curious: Is there a way to make that work? If not, I guess that's fine, but it's a bit challenging as is to keep Compose, Kotlin and AGP versions aligned, growing the "coupled dependencies list" further would ideally be avoidable? (not sure if that's a reasonable ask tbh)

@JakeWharton
Copy link
Contributor

Compose is part of Kotlin now. There's no compatibility problems or coupling. Kotlin and AGP can also be upgraded independently.

The only coupling is Poko and Kotlin, as compiler plugins are not stable.

@jrodbx jrodbx merged commit 70f7c81 into master Aug 26, 2024
14 checks passed
@jrodbx jrodbx deleted the renovate/kotlin-and-compose branch August 26, 2024 19:58
ribafish added a commit to ribafish/paparazzi that referenced this pull request Aug 28, 2024
* master: (23 commits)
  Hash collision fix (cashapp#1556)
  Update Kotlin and Compose (cashapp#1549)
  Update dependency dev.drewhamilton.poko:poko-gradle-plugin to v0.17.0 (cashapp#1550)
  Fix file movement when taking snapshots  (cashapp#1535)
  Always sanitize the snapshot filename (cashapp#1553)
  Update dependency mkdocs-material to v9.5.33 (cashapp#1552)
  Update bytebuddy to v1.15.0 (cashapp#1551)
  Update dependency org.jetbrains.kotlinx:binary-compatibility-validator to v0.16.3 (cashapp#1507)
  Update dependency gradle to v8.10 (cashapp#1536)
  Update dependency mkdocs-material to v9.5.32 (cashapp#1543)
  Update plugin com.gradle.develocity to v3.18 (cashapp#1542)
  Replace all accessing of gradle properties (cashapp#1541)
  Update dependency com.google.guava:guava to v33.3.0-jre (cashapp#1540)
  Update dependency Markdown to <3.8 (cashapp#1539)
  Update bytebuddy to v1.14.19 (cashapp#1538)
  Test windows failure for invalid snapshot chars (cashapp#1534)
  Update Kotlin and Compose (cashapp#1516)
  Fix tests dependent on locale (cashapp#1521)
  Update gradle/actions action to v4 (cashapp#1525)
  Update dependency androidx.annotation:annotation to v1.8.2 (cashapp#1530)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants