Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #282. See the individual commits.
Let me know what you think of it so far, and happy to help with other things, if necessary, but also feel free to commit and finish this branch/PR.
Few things of note left to do (anyone can chip in!):
(unless you're ok with
paparazzi.instance.snapshot
)registerInterceptors
to PaparazziExtension (I didn't do this because it wasn't clear what was your intended lifecycle of this. I'm not sure if it's defined when the body ofTestRule.apply
is executed. I don't think that can be relied on as a "lifecycle" event. Anyway, I'm sure there's a fitting lifecycle interface inorg.junit.jupiter.api.extension
package.@Parameterized
tests, JUnitParams@Parameters(...)
or JUnit Jupiter@ParameterizedTest
.